Fix team edit API panic#6780
Merged
Merged
Conversation
lafriks
reviewed
Apr 27, 2019
GiteaBot
added
the
lgtm/need 2
Member
|
Thanks for adding tests 👍 small nit but otherwise LGTM |
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #6780 +/- ##
==========================================
+ Coverage 40.99% 41.22% +0.22%
==========================================
Files 421 421
Lines 58054 58054
==========================================
+ Hits 23802 23933 +131
+ Misses 31086 30954 -132
- Partials 3166 3167 +1
Continue to review full report at Codecov.
|
Co-Authored-By: ngourdon <31291059+ngourdon@users.noreply.github.com>
techknowlogick
approved these changes
Apr 27, 2019
GiteaBot
added
lgtm/done
Member
|
@ngourdon thanks for PR :) would you be able to backport this PR to the release/v1.8 branch? |
lafriks
added
backport/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #6777 and add tests for team API